Skip to content

fix: CORS errors when sending tracked headers other than Flagsmith-SDK-User-Agent#6017

Merged
khvn26 merged 1 commit intomainfrom
fix/cors-tracked-headers
Sep 3, 2025
Merged

fix: CORS errors when sending tracked headers other than Flagsmith-SDK-User-Agent#6017
khvn26 merged 1 commit intomainfrom
fix/cors-tracked-headers

Conversation

@khvn26
Copy link
Copy Markdown
Member

@khvn26 khvn26 commented Sep 3, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This PR is a continuation of #6010. It includes other tracked headers to CORS exclusion list, and makes sure that each header is included only once.

How did you test this code?

Tested locally, and will test on staging.

@khvn26 khvn26 requested a review from a team as a code owner September 3, 2025 15:24
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team September 3, 2025 15:24
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Sep 3, 2025 3:24pm
flagsmith-frontend-preview Ignored Ignored Sep 3, 2025 3:24pm
flagsmith-frontend-staging Ignored Ignored Sep 3, 2025 3:24pm

@github-actions github-actions Bot added the api Issue related to the REST API label Sep 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 3, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6017 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-6017 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6017 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6017 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6017 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6017 Finished ✅ Results

@github-actions github-actions Bot added the fix label Sep 3, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.86%. Comparing base (332a2df) to head (13e72c9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6017   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files        1276     1276           
  Lines       45315    45316    +1     
=======================================
+ Hits        44349    44350    +1     
  Misses        966      966           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 merged commit 8a066a8 into main Sep 3, 2025
30 checks passed
@khvn26 khvn26 deleted the fix/cors-tracked-headers branch September 3, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants