Skip to content

fix: get-identities-checks-existing-invalid-identifiers#6083

Merged
emyller merged 7 commits intomainfrom
fix/identity-sanitization-retrocompatibility
Sep 17, 2025
Merged

fix: get-identities-checks-existing-invalid-identifiers#6083
emyller merged 7 commits intomainfrom
fix/identity-sanitization-retrocompatibility

Conversation

@Zaimwa9
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 commented Sep 17, 2025

Contributes to #6082


Changes

  • Allow white spaces in identifiers.

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner September 17, 2025 15:34
@Zaimwa9 Zaimwa9 requested review from emyller and khvn26 and removed request for a team and khvn26 September 17, 2025 15:34
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs Ignored Ignored Preview Sep 17, 2025 4:50pm
flagsmith-frontend-preview Ignored Ignored Preview Sep 17, 2025 4:50pm
flagsmith-frontend-staging Ignored Ignored Preview Sep 17, 2025 4:50pm

@github-actions github-actions Bot added the api Issue related to the REST API label Sep 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 17, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6083 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6083 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6083 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6083 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6083 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6083 Finished ✅ Results

@github-actions github-actions Bot added the fix label Sep 17, 2025
@github-actions github-actions Bot added fix and removed fix labels Sep 17, 2025
@github-actions github-actions Bot added fix and removed fix labels Sep 17, 2025
Copy link
Copy Markdown
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the fix to be allowing white spaces in the validation regex.

Comment thread api/environments/identities/constants.py Outdated
Comment thread api/environments/identities/serializers.py Outdated
@github-actions github-actions Bot added fix and removed fix labels Sep 17, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.00%. Comparing base (75246b1) to head (38ee6f5).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6083   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files        1277     1278    +1     
  Lines       44980    44986    +6     
=======================================
+ Hits        44082    44088    +6     
  Misses        898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

….com:Flagsmith/flagsmith into fix/identity-sanitization-retrocompatibility
@github-actions github-actions Bot added fix and removed fix labels Sep 17, 2025
Copy link
Copy Markdown
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emyller emyller merged commit ea58867 into main Sep 17, 2025
31 checks passed
@emyller emyller deleted the fix/identity-sanitization-retrocompatibility branch September 17, 2025 17:09
emyller added a commit that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants