fix(features): fix cache isolation for server-only features#6092
Merged
matthewelwell merged 2 commits intoFlagsmith:mainfrom Sep 23, 2025
Merged
fix(features): fix cache isolation for server-only features#6092matthewelwell merged 2 commits intoFlagsmith:mainfrom
matthewelwell merged 2 commits intoFlagsmith:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
@blackjid is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6092 +/- ##
==========================================
- Coverage 98.00% 97.99% -0.01%
==========================================
Files 1277 1278 +1
Lines 44980 44925 -55
==========================================
- Hits 44082 44026 -56
- Misses 898 899 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Fixed a cache isolation bug where server-only features could leak to client requests. And the other way around, where server-only keys could not be presented because they are cached from a client request.
Problem:
The features endpoint cache used only
environment.api_keyas the cache key. Both CLIENT and SERVER requests shared the same cache, so server-only features cached by server requests could be served to client requests.Solution:
Updated the cache key to include request origin:
f"{environment.api_key}:{request_origin}"Now CLIENT and SERVER requests have separate cache entries:
env_123:CLIENTenv_123:SERVERFiles changed:
api/features/views.py- Fixed cache keyapi/tests/unit/features/test_unit_features_views.py- Added testHow did you test this code?
TDD approach:
Results: