fix: update permission test query counts for RBAC#6547
Merged
gagantrivedi merged 1 commit intomainfrom Jan 19, 2026
Merged
Conversation
Update expected query counts in permission tests to account for the additional RBAC role permission check when IS_RBAC_INSTALLED is True.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6547 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 1293 1293
Lines 46607 46610 +3
=======================================
+ Hits 45719 45722 +3
Misses 888 888 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Zaimwa9
approved these changes
Jan 19, 2026
Contributor
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
I remember having seen something already 🤔
matthewelwell
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Follows up on #6537
Updates expected query counts in permission tests to account for the additional RBAC role permission check when
IS_RBAC_INSTALLEDis True.test_is_user_environment_admin__short_circuits_on_direct_permission: 6 → 7 queries with RBACtest_is_user_environment_admin__short_circuits_on_group_permission: 7 → 8 queries with RBACtest_view_environment_with_staff__query_count_is_expected_with_rbac: 12 → 13 queriesHow did you test this code?
Ran the affected tests with RBAC enabled in CI.