Skip to content

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Jan 26, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

In this PR, we:

  1. Run private package tests on both supported Python versions.
  2. Upload coverage for private package tests to improve project coverage for PRs.
  3. Switch to OIDC-based auth for Codecov.

How did you test this code?

This is a CI change — once CI passes, it's ready to go.

@khvn26 khvn26 requested a review from a team as a code owner January 26, 2026 09:58
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team January 26, 2026 09:58
@vercel
Copy link

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Review Updated (UTC)
docs Ignored Ignored Jan 26, 2026 9:58am
flagsmith-frontend-preview Ignored Ignored Jan 26, 2026 9:58am
flagsmith-frontend-staging Ignored Ignored Jan 26, 2026 9:58am

Request Review

@github-actions github-actions bot added the ci-cd Build, test and deployment related label Jan 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-6594 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-6594 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6594 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6594 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6594 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6594 Finished ✅ Results

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.18%. Comparing base (9838589) to head (f588900).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6594      +/-   ##
==========================================
+ Coverage   98.16%   98.18%   +0.01%     
==========================================
  Files        1295     1295              
  Lines       46793    46920     +127     
==========================================
+ Hits        45934    46067     +133     
+ Misses        859      853       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 requested a review from Zaimwa9 January 26, 2026 10:21
@khvn26 khvn26 merged commit a5c46e0 into main Jan 26, 2026
33 checks passed
@khvn26 khvn26 deleted the ci/codecov-for-private-packages branch January 26, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Build, test and deployment related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants