Skip to content

chore: Add type hints to Chargebee functions#6790

Merged
khvn26 merged 5 commits intomainfrom
chore/chargebee-type-ignores
Feb 26, 2026
Merged

chore: Add type hints to Chargebee functions#6790
khvn26 merged 5 commits intomainfrom
chore/chargebee-type-ignores

Conversation

@khvn26
Copy link
Member

@khvn26 khvn26 commented Feb 26, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

In this PR, we add type hints to our Chargebee code so it's slightly more pleasant to work with.

How did you test this code?

The changes are non-functional. All existing tests pass. Newly added explicit return None branches are covered by new tests.

@khvn26 khvn26 requested a review from a team as a code owner February 26, 2026 15:33
@khvn26 khvn26 requested review from Zaimwa9 and removed request for a team February 26, 2026 15:33
@vercel
Copy link

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Feb 26, 2026 4:32pm
flagsmith-frontend-preview Ignored Ignored Preview Feb 26, 2026 4:32pm
flagsmith-frontend-staging Ignored Ignored Preview Feb 26, 2026 4:32pm

Request Review

@github-actions github-actions bot added api Issue related to the REST API chore labels Feb 26, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-6790 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6790 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6790 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6790 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-6790 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6790 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6790 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6790 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api-test:pr-6790 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6790 Finished ✅ Results

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.30%. Comparing base (9a09772) to head (e3ff982).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6790      +/-   ##
==========================================
+ Coverage   98.28%   98.30%   +0.01%     
==========================================
  Files        1330     1331       +1     
  Lines       49255    49332      +77     
==========================================
+ Hits        48412    48494      +82     
+ Misses        843      838       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added chore and removed chore labels Feb 26, 2026
@github-actions github-actions bot added chore and removed chore labels Feb 26, 2026
emyller
emyller previously approved these changes Feb 26, 2026
@khvn26 khvn26 requested a review from emyller February 26, 2026 16:32
@github-actions github-actions bot added chore and removed chore labels Feb 26, 2026
@khvn26 khvn26 merged commit 5df4fe9 into main Feb 26, 2026
33 checks passed
@khvn26 khvn26 deleted the chore/chargebee-type-ignores branch February 26, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants