fix: dark-mode-on-login-page#6810
Conversation
kartik-lamkhade
requested review from
talissoncosta
and removed request for
a team
|
@kartik-lamkhade is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
the
front-end
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Free Tier Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
Thanks for the contribution (and reactivity to this issue!). I have a couple of comments, mostly related to our identification of the issue.
The root issue is that in frontend/web/components/pages/HomePage.tsx L351 in Card we use the class bg-white that is not dark-mode aware.
So in addition to your fix (to keep the dark mode even after storage clearance) we would need to replace bg-white with bg-body that is dark mode aware.
Could you also rename the PR name to Fix: xxxx to pass the CI step please ? We should be good to go then!
Thanks again
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the contribution :)
2 participants
Fix #6804
fix(frontend): resolve dark mode resetting issue
fix(ui): correct body color in dark mode