fix: Fix "unsaved changes" badge positioning on Edit Feature modal tabs#6969
fix: Fix "unsaved changes" badge positioning on Edit Feature modal tabs#6969JiwaniZakir wants to merge 2 commits intoFlagsmith:mainfrom
Conversation
|
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage. Once credits are available, reopen this pull request to trigger a review. |
|
@JiwaniZakir is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
the
front-end
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| tabLabel={ | ||
| <Row | ||
| className={`justify-content-center ${ | ||
| className={`justify-content-center align-items-center ${ |
There was a problem hiding this comment.
Alignment fix applied to only one of three tabs
Medium Severity
The align-items-center fix is only applied to the Segment Overrides tab Row, but the Value tab (line 850) and Settings tab (line 1679) use the identical Row + unsaved-changes badge pattern with only justify-content-center. Before this change, all three badge tabs were equally misaligned; now only Segment Overrides is corrected, creating a visible inconsistency between tabs with unsaved changes indicators.
|
Hey @JiwaniZakir , thanks for picking this up! 🙏 Could you add before/after screenshots to the PR description? It'll help us validate the fix visually and speed up the review. Thanks again for the contribution! |
talissoncosta
requested review from
talissoncosta
and removed request for
kyle-ssg
|
Sure! I'll add before/after screenshots to the PR description shortly. |
2 participants
Fixes #6935
The "unsaved changes" badge on the Segment Overrides tab in the Edit Feature modal was rendered out of vertical alignment. The
Rowwrapper increate-feature/index.jsonly appliedjustify-content-center, leaving the badge offset vertically relative to the tab label text. Addingalign-items-centerto thatRow's className corrects the vertical alignment. Minor whitespace inconsistencies in_tabs.scssare cleaned up alongside the fix.