fix(GitHub Integration): Fix JWT generation for GitHub API calls#6983
fix(GitHub Integration): Fix JWT generation for GitHub API calls#6983
Conversation
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6983 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 1334 1335 +1
Lines 49748 49782 +34
=======================================
+ Hits 48911 48945 +34
Misses 837 837 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
docs/if required so people know about the feature.Changes
Closes #6979
All GitHub integration API calls fail with
TypeError: Issuer (iss) must be a string.(FLAGSMITH-API-5K9).Our
GITHUB_APP_IDsetting is an integer. PyGithub 2.1.1 passes it directly to the JWTissclaim, which worked until #6950 bumped PyJWT to 2.12.0 — a version that validatesissas a string per RFC 7519.PyGithub already fixed this in v2.7.0 by converting
app_idto string internally. This PR upgrades PyGithub to ~2.8 and adds an explicitstr()call in our code as a safeguard.How did you test this code?
New unit tests exercising the full PyGithub + PyJWT stack.