fix: Schedule Update on Segment Overrides shows 'Feature contains no changes'#6996
Conversation
When clicking "Schedule Update" on the Segment Overrides tab, saveFeatureSegments delegates to saveFeatureValue() without forwarding the schedule argument. This causes the change request flow to be skipped entirely (when 4-eyes is disabled), falling through to a direct value save that fails with "Feature contains no changes". Introduced in 00085cd (feat: Edit Change Requests #6356). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
front-end
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
3 participants
docs/if required so people know about the feature.Changes
Closes #6997
When clicking "Schedule Update" on the Segment Overrides tab,
saveFeatureSegmentsdelegates tosaveFeatureValue()without forwarding thescheduleargument. This causes the change request flow to be skipped entirely (when 4-eyes approval is not enabled), falling through to a direct value save that fails with "Feature contains no changes".The fix passes the
scheduleflag through:saveFeatureValue()→saveFeatureValue(schedule).Introduced in 00085cd (feat: Edit Change Requests #6356).
How did you test this code?