Skip to content

fix(chargebee): Handle addon ids per billing period#7108

Merged
matthewelwell merged 6 commits intomainfrom
fix/handle-add-on-ids-per-billing-period
Apr 2, 2026
Merged

fix(chargebee): Handle addon ids per billing period#7108
matthewelwell merged 6 commits intomainfrom
fix/handle-add-on-ids-per-billing-period

Conversation

@matthewelwell
Copy link
Copy Markdown
Contributor

Changes

Following testing in staging after merging this PR it turns out that we do need to send the right suffix depending on the billing period for the addon.

How did you test this code?

Updated the unit tests and tested manually by setting the staging credentials in my terminal and running python manage.py shell. I will also test via the staging dashboard once deployed.

@matthewelwell matthewelwell requested a review from a team as a code owner April 2, 2026 14:30
@matthewelwell matthewelwell requested review from Zaimwa9 and removed request for a team April 2, 2026 14:30
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 2, 2026 3:43pm
flagsmith-frontend-preview Ignored Ignored Preview Apr 2, 2026 3:43pm
flagsmith-frontend-staging Ignored Ignored Preview Apr 2, 2026 3:43pm

Request Review

@github-actions github-actions bot added api Issue related to the REST API fix labels Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7108 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7108 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7108 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7108 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7108 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7108 Finished ✅ Results

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.33%. Comparing base (3e3be2e) to head (301c72e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7108   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files        1335     1335           
  Lines       49930    49939    +9     
=======================================
+ Hits        49100    49109    +9     
  Misses        830      830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  9 seconds
commit  e99fdf7
info  🔄 Run: #15658 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  50.4 seconds
commit  e99fdf7
info  🔄 Run: #15658 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  44.2 seconds
commit  e99fdf7
info  🔄 Run: #15658 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  55.6 seconds
commit  e99fdf7
info  🔄 Run: #15658 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  19.6 seconds
commit  3b54a63
info  🔄 Run: #15660 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  50.2 seconds
commit  3b54a63
info  🔄 Run: #15660 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  57.7 seconds
commit  3b54a63
info  🔄 Run: #15660 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  49.8 seconds
commit  3b54a63
info  🔄 Run: #15660 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  11.1 seconds
commit  172fd45
info  🔄 Run: #15661 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  27.9 seconds
commit  172fd45
info  🔄 Run: #15661 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  50 seconds
commit  172fd45
info  🔄 Run: #15661 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 5 seconds
commit  172fd45
info  🔄 Run: #15661 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  46.6 seconds
commit  301c72e
info  🔄 Run: #15664 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  29.1 seconds
commit  301c72e
info  🔄 Run: #15664 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  44.1 seconds
commit  301c72e
info  🔄 Run: #15664 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 8 seconds
commit  301c72e
info  🔄 Run: #15664 (attempt 1)

Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sniffing some dead-code. Otherwise it does look good but I don't have full context over the config

@github-actions github-actions bot added fix and removed fix labels Apr 2, 2026
@github-actions github-actions bot added fix and removed fix labels Apr 2, 2026
@matthewelwell matthewelwell requested a review from Zaimwa9 April 2, 2026 15:43
@github-actions github-actions bot added fix and removed fix labels Apr 2, 2026
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matthewelwell matthewelwell merged commit db02299 into main Apr 2, 2026
36 checks passed
@matthewelwell matthewelwell deleted the fix/handle-add-on-ids-per-billing-period branch April 2, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants