Skip to content

fix(ci): improve Chromatic workflow#7156

Merged
talissoncosta merged 1 commit intomainfrom
fix/chromatic-workflow-config
Apr 7, 2026
Merged

fix(ci): improve Chromatic workflow#7156
talissoncosta merged 1 commit intomainfrom
fix/chromatic-workflow-config

Conversation

@talissoncosta
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta commented Apr 7, 2026

  • I have read the Contributing Guide.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Three fixes to the Chromatic CI workflow:

1. Run on push to main

Previously only ran on PRs. Without a main build, Chromatic has no baseline — every PR shows all stories as "new changes" requiring manual acceptance (the 50 pending changes issue).

2. Auto-accept on main

autoAcceptChanges: main automatically accepts all changes when merging to main. Main is the source of truth — no manual review needed. Future PRs compare against this auto-updated baseline.

3. Narrow path filter

Previously triggered on any frontend/** change. Now only triggers on files that affect Storybook rendering:

  • frontend/web/components/**
  • frontend/web/styles/**
  • frontend/common/theme/**
  • frontend/documentation/**
  • frontend/.storybook/**

E2E tests, configs, and other non-UI files no longer trigger Chromatic.

How did you test this code?

  • Verified workflow YAML syntax
  • Confirmed autoAcceptChanges parameter is supported by chromaui/action@v11
  • Verified if condition handles both push and pull_request events

@talissoncosta talissoncosta requested a review from a team as a code owner April 7, 2026 15:05
@talissoncosta talissoncosta requested review from emyller and removed request for a team April 7, 2026 15:05
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 7, 2026 4:24pm
flagsmith-frontend-preview Ignored Ignored Preview Apr 7, 2026 4:24pm
flagsmith-frontend-staging Ignored Ignored Preview Apr 7, 2026 4:24pm

Request Review

@github-actions github-actions bot added the fix label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7156 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7156 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-e2e:pr-7156 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-7156 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7156 Finished ✅ Results ✅

@talissoncosta talissoncosta requested a review from Zaimwa9 April 7, 2026 15:10
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.34%. Comparing base (6bf055c) to head (2a70efb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7156      +/-   ##
==========================================
+ Coverage   98.27%   98.34%   +0.07%     
==========================================
  Files        1336     1336              
  Lines       50047    50174     +127     
==========================================
+ Hits        49182    49344     +162     
+ Misses        865      830      -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@talissoncosta talissoncosta removed the request for review from emyller April 7, 2026 15:12
@github-actions github-actions bot added fix and removed fix labels Apr 7, 2026
@talissoncosta talissoncosta force-pushed the fix/chromatic-workflow-config branch from f754ead to e1c776e Compare April 7, 2026 15:17
@github-actions github-actions bot added fix and removed fix labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  23.5 seconds
commit  2034065
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15835 (attempt 1)

Failed tests

firefox › tests/sdk-keys-test.pw.ts › SDK Keys Tests › Server-side SDK keys can be created and deleted @oss

### Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  22.4 seconds
commit  2034065
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15835 (attempt 1)

Failed tests

firefox › tests/sdk-keys-test.pw.ts › SDK Keys Tests › Server-side SDK keys can be created and deleted @oss

### Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  23.3 seconds
commit  f754ead
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15836 (attempt 1)

Failed tests

firefox › tests/sdk-keys-test.pw.ts › SDK Keys Tests › Server-side SDK keys can be created and deleted @oss

### Playwright Test Results (oss - depot-ubuntu-latest-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  22.5 seconds
commit  e1c776e
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15837 (attempt 1)

Failed tests

firefox › tests/sdk-keys-test.pw.ts › SDK Keys Tests › Server-side SDK keys can be created and deleted @oss

### Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  23.4 seconds
commit  f754ead
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15836 (attempt 1)

Failed tests

firefox › tests/sdk-keys-test.pw.ts › SDK Keys Tests › Server-side SDK keys can be created and deleted @oss

### Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  23.4 seconds
commit  e1c776e
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15837 (attempt 1)

Failed tests

firefox › tests/sdk-keys-test.pw.ts › SDK Keys Tests › Server-side SDK keys can be created and deleted @oss

### Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  22.5 seconds
commit  e1c776e
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15837 (attempt 3)

Failed tests

firefox › tests/sdk-keys-test.pw.ts › SDK Keys Tests › Server-side SDK keys can be created and deleted @oss

### Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  23.5 seconds
commit  e1c776e
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15837 (attempt 3)

Failed tests

firefox › tests/sdk-keys-test.pw.ts › SDK Keys Tests › Server-side SDK keys can be created and deleted @oss

### Playwright Test Results (oss - depot-ubuntu-latest-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  22.9 seconds
commit  e1c776e
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15837 (attempt 4)

Failed tests

firefox › tests/sdk-keys-test.pw.ts › SDK Keys Tests › Server-side SDK keys can be created and deleted @oss

### Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

failed  1 failed

Details

stats  1 test across 1 suite
duration  22.4 seconds
commit  e1c776e
info  📦 Artifacts: View test results and HTML report
🔄 Run: #15837 (attempt 4)

Failed tests

firefox › tests/sdk-keys-test.pw.ts › SDK Keys Tests › Server-side SDK keys can be created and deleted @oss

### Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  46.1 seconds
commit  2a70efb
info  🔄 Run: #15839 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  1.3 seconds
commit  2a70efb
info  🔄 Run: #15839 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 2 seconds
commit  2a70efb
info  🔄 Run: #15839 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  53.6 seconds
commit  2a70efb
info  🔄 Run: #15839 (attempt 1)

@talissoncosta talissoncosta requested a review from emyller April 7, 2026 15:48
@github-actions github-actions bot added fix and removed fix labels Apr 7, 2026
@talissoncosta @claude
fix(ci): improve Chromatic workflow — auto-accept on main, path filter
2a70efb 
- Run on push to main to establish baselines (was PR-only)
- autoAcceptChanges on main — no manual review needed for source of truth
- Narrow path filter for main push (components, styles, storybook only)
- Broad path filter for PRs (frontend/**) to catch indirect regressions
- Fix if condition to handle both push and pull_request events

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@talissoncosta talissoncosta force-pushed the fix/chromatic-workflow-config branch from e1c776e to 2a70efb Compare April 7, 2026 16:24
@github-actions github-actions bot added fix and removed fix labels Apr 7, 2026
@talissoncosta talissoncosta added the front-end Issue related to the React Front End Dashboard label Apr 7, 2026
talissoncosta
talissoncosta commented Apr 7, 2026
View reviewed changes
@talissoncosta talissoncosta changed the title fix(ci): improve Chromatic workflow — path filter and auto-accept on main fix(ci): improve Chromatic workflow Apr 7, 2026
@talissoncosta talissoncosta merged commit db4e578 into main Apr 7, 2026
37 checks passed
@talissoncosta talissoncosta deleted the fix/chromatic-workflow-config branch April 7, 2026 16:41
@flagsmithdev flagsmithdev mentioned this pull request Apr 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emyller emyller emyller approved these changes

@Zaimwa9 Zaimwa9 Awaiting requested review from Zaimwa9

Assignees

No one assigned

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@talissoncosta @emyller