refactor: Move icons, remove unused files#7171
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
bot
added
front-end
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Failed testsfirefox › tests/change-request-test.pw.ts › Change Request Tests › Change requests can be created, approved, and published with 4-eyes approval @enterprise
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Failed testsfirefox › tests/segment-test.pw.ts › Segment test 1 - Create, update, and manage segments with multivariate flags @oss
Details
Failed testsfirefox › tests/segment-test.pw.ts › Segment test 1 - Create, update, and manage segments with multivariate flags @oss
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
…to refactor/delete-unused-files
talissoncosta
left a comment
talissoncosta
left a comment
There was a problem hiding this comment.
LGTM. Good use of knip for the sweep, and the icon reorganisation makes the folder structure cleaner. Monster PR but entirely safe deletions and import path updates, which made it straightforward to review. :smiling
3 participants
Thanks for submitting a PR! Please check the boxes below:
Changes
Remove 36 unused frontend files identified via knip static analysis, verified with manual grep cross-referencing.
Move icons to icons folder.
Dead pages (3):
ComingSoonPage,ConfirmEmailPage,HomeAside— zero references anywhere in the codebase.Dead components (11):
AsideProjectButton,AsideTitleLink,Collapsible,Confidence,ConversionEventSelect,ExistingChangeRequestAlert,HistoryIcon,MetadataTitle,ProjectSelect,RebrandBanner,Resources— no imports found.Unused SVG icons (14):
ArrowUpIcon,CaretDownIcon,CaretRightIcon,DocumentationIcon,EnvironmentSettingsIcon,FeaturesIcon,LogoutIcon,OrgSettingsIcon,PlayIcon,PlusIcon,ProjectSettingsIcon,SparklesIcon,UpgradeIcon,UserSettingsIcon— none importedanywhere.
Unused hooks/services (4):
useMediaQuery,useConversionEvent,mockAdminDashboardData,useSetupCustomWidget— zero consumers.Dead base files (3):
format-base.js,utils-base.js,base/forms/Tabs.js— zero imports.Duplicate TS migration leftover (1):
CreateWebhook.js— the.tsxversion is what webpack resolves (.tsxcomes before.jsin resolveextensions).
Unused exports - to clear up what's used vs not I've removed any unused exports e.g. types / variables that are just used within that file.
How did you test this code?
knipto identify unused files via static analysis of the import graph.npm run typecheck— error count went from 771 → 747 (24 fewer, all from deleted files that previously had errors). No new errors introduced.ps: Apologies in advance for monster PR