Skip to content

refactor: rspack#7184

Merged
kyle-ssg merged 5 commits intorefactor/esmfrom
feat/rspack
Apr 8, 2026
Merged

refactor: rspack#7184
kyle-ssg merged 5 commits intorefactor/esmfrom
feat/rspack

Conversation

@kyle-ssg
Copy link
Copy Markdown
Member

@kyle-ssg kyle-ssg commented Apr 8, 2026 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Migrates webpack to rspack, a Rust based build system by ByteDance.

Improves local developer experience and build time from roughly 36 seconds to 4.5-5s

image image

Note: It seems we will still need a lot of the original webpack plugins due to storybook / chromatic

How did you test this code?

Mainly builds (local + vercel) and then also E2E running on docker images

@kyle-ssg kyle-ssg requested a review from a team as a code owner April 8, 2026 13:46
@kyle-ssg kyle-ssg requested review from talissoncosta and removed request for a team April 8, 2026 13:46
claude[bot]
claude bot reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 8, 2026 3:32pm
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 8, 2026 3:32pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 8, 2026 3:32pm

Request Review

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Apr 8, 2026
@kyle-ssg kyle-ssg requested a review from a team April 8, 2026 13:46
@kyle-ssg kyle-ssg changed the title Feat/rspack feat: rspack Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7184 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7184 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7184 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7184 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api-test:pr-7184 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7184 Finished ✅ Results ✅

@kyle-ssg kyle-ssg changed the title feat: rspack refactor: rspack Apr 8, 2026
@kyle-ssg @claude
Reinstall raw-loader as devDependency for Storybook
0919cc8 
Storybook's webpack5 builder still needs raw-loader which was removed
during the rspack migration.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  42.3 seconds
commit  63a116e
info  🔄 Run: #15884 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  49.5 seconds
commit  63a116e
info  🔄 Run: #15884 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  53.5 seconds
commit  63a116e
info  🔄 Run: #15884 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  29.2 seconds
commit  63a116e
info  🔄 Run: #15884 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  28.4 seconds
commit  0919cc8
info  🔄 Run: #15885 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  53.3 seconds
commit  0919cc8
info  🔄 Run: #15885 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  55 seconds
commit  0919cc8
info  🔄 Run: #15885 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 1 second
commit  0919cc8
info  🔄 Run: #15885 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  41.6 seconds
commit  1be6185
info  🔄 Run: #15887 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  28.4 seconds
commit  1be6185
info  🔄 Run: #15887 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  59.5 seconds
commit  1be6185
info  🔄 Run: #15887 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  47.1 seconds
commit  1be6185
info  🔄 Run: #15887 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  37.8 seconds
commit  465440f
info  🔄 Run: #15895 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  48.9 seconds
commit  465440f
info  🔄 Run: #15895 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  52.4 seconds
commit  465440f
info  🔄 Run: #15895 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 5 seconds
commit  465440f
info  🔄 Run: #15895 (attempt 1)

@github-actions github-actions bot added refactor and removed refactor labels Apr 8, 2026
@github-actions github-actions bot added refactor and removed refactor labels Apr 8, 2026
@kyle-ssg kyle-ssg linked an issue Apr 8, 2026 that may be closed by this pull request
Investigate vite over webpack #7175
Open
talissoncosta
talissoncosta approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@talissoncosta talissoncosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice migration — the build speed improvement is massive. One thought for a future follow-up: now that the main build is on rspack, we could migrate Storybook to @storybook/builder-vite to drop webpack from the dependency tree entirely. Both builders are available for Storybook 10.

Comment thread frontend/rspack/rspack.config.local.js
@kyle-ssg kyle-ssg merged commit d0836e6 into refactor/esm Apr 8, 2026
26 checks passed
@kyle-ssg kyle-ssg deleted the feat/rspack branch April 8, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@talissoncosta talissoncosta talissoncosta approved these changes

Assignees

No one assigned

Labels

front-end Issue related to the React Front End Dashboard refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate vite over webpack

2 participants

@kyle-ssg @talissoncosta