Skip to content

feat(GitLab): Browse GitLab issues and merge requests (backend)#7270

Merged
emyller merged 3 commits intomainfrom
feat/gitlab-link-issues-mrs
Apr 17, 2026
Merged

feat(GitLab): Browse GitLab issues and merge requests (backend)#7270
emyller merged 3 commits intomainfrom
feat/gitlab-link-issues-mrs

Conversation

@emyller
Copy link
Copy Markdown
Contributor

@emyller emyller commented Apr 16, 2026 •
edited
Loading

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #7160

Stack: #7270 (this) → #7273 (frontend) → #7274 (linking)

Allow browsing issues and merge requests in GitLab from the feature modal. This pull request adds the backend proxy endpoints that talk to the GitLab API v4 using the connection credentials stored via #7239. Frontend and linking follow in the stack.

Review effort: 2/5

How did you test this code?

Unit tests and manual API hammering.

How to review

  • Some diff is added because of moving gitlab/views.py to gitlab/views/configuration.py.
  • Start from URLs, then views, then the API code at gitlab/client/api.py.
    • Looking at screenshots in the next issues might help!
    • Tip: each view has a 1:1 relationship to a client function.

@emyller emyller self-assigned this Apr 16, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 16, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 17, 2026 5:09pm
flagsmith-frontend-preview Ignored Ignored Preview Apr 17, 2026 5:09pm
flagsmith-frontend-staging Ignored Ignored Preview Apr 17, 2026 5:09pm

Request Review

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Apr 16, 2026
github-advanced-security[bot]
github-advanced-security AI found potential problems Apr 16, 2026
View reviewed changes
Comment thread api/integrations/gitlab/views/browse_gitlab.py Fixed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.37%. Comparing base (9530f35) to head (7f34034).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7270      +/-   ##
==========================================
+ Coverage   98.29%   98.37%   +0.07%     
==========================================
  Files        1357     1364       +7     
  Lines       50851    51071     +220     
==========================================
+ Hits        49984    50239     +255     
+ Misses        867      832      -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@emyller emyller force-pushed the feat/gitlab-link-issues-mrs branch from f2a5cde to f64778f Compare April 16, 2026 21:02
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request and removed feature New feature or request labels Apr 16, 2026
@emyller emyller force-pushed the feat/gitlab-link-issues-mrs branch from f64778f to 965031c Compare April 17, 2026 00:07
@github-actions github-actions bot removed the feature New feature or request label Apr 17, 2026
@github-actions github-actions bot added the feature New feature or request label Apr 17, 2026
@emyller emyller force-pushed the feat/gitlab-link-issues-mrs branch from 965031c to c644394 Compare April 17, 2026 00:18
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 17, 2026
This was referenced Apr 17, 2026
Open
Open
@emyller emyller changed the title feat(GitLab): Link GitLab issues and MRs to Flagsmith features feat(GitLab): Browse GitLab issues and merge requests (backend) Apr 17, 2026
@emyller emyller marked this pull request as ready for review April 17, 2026 00:48
@emyller emyller requested a review from a team as a code owner April 17, 2026 00:48
@emyller emyller requested review from khvn26 and removed request for a team April 17, 2026 00:48
claude[bot]
claude bot reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7270 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7270 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7270 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-7270 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7270 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7270 Finished ✅ Results ✅

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  43.9 seconds
commit  c644394
info  🔄 Run: #16156 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  51.4 seconds
commit  c644394
info  🔄 Run: #16156 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  59.9 seconds
commit  c644394
info  🔄 Run: #16156 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  56.5 seconds
commit  c644394
info  🔄 Run: #16156 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  27.9 seconds
commit  7f34034
info  🔄 Run: #16166 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  11.4 seconds
commit  7f34034
info  🔄 Run: #16166 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  52.9 seconds
commit  7f34034
info  🔄 Run: #16166 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

failed  2 failed

Details

stats  2 tests across 2 suites
duration  1 minute, 9 seconds
commit  7f34034
info  📦 Artifacts: View test results and HTML report
🔄 Run: #16166 (attempt 1)

Failed tests

firefox › tests/environment-permission-test.pw.ts › Environment Permission Tests › Environment-level permissions control access to features, identities, and segments @enterprise
firefox › tests/project-permission-test.pw.ts › Project Permission Tests › Project-level permissions control access to features, environments, audit logs, and segments @enterprise

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026 •
edited
Loading

Visual Regression

16 screenshots compared. See report for details.
View full report

khvn26
khvn26 previously approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. Just 1 minor comment.

Comment thread api/integrations/gitlab/views/browse_gitlab.py Outdated
@Zaimwa9 Zaimwa9 removed the front-end Issue related to the React Front End Dashboard label Apr 17, 2026
@emyller emyller requested a review from khvn26 April 17, 2026 17:09
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Apr 17, 2026
@emyller emyller merged commit 1b8145a into main Apr 17, 2026
34 of 35 checks passed
@emyller emyller deleted the feat/gitlab-link-issues-mrs branch April 17, 2026 17:18
@flagsmithdev flagsmithdev mentioned this pull request Apr 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@khvn26 khvn26 khvn26 approved these changes

+1 more reviewer

@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@emyller emyller

Labels

api Issue related to the REST API feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emyller @khvn26 @github-advanced-security @Zaimwa9