feat(GitLab): Post comments when linking an issue or merge request to a Flagsmith feature by emyller · Pull Request #7306 · Flagsmith/flagsmith

emyller · 2026-04-22T04:18:02Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
~~I have added information to docs/ if required so people know about the feature.~~
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Post comments to GitLab issues and merge requests when:

A feature is linked to an issue or MR (initial state snapshot table across environments)
A linked feature's state changes for any environment, segment, or identity
A feature is unlinked from an issue or MR
A linked feature is deleted

State-change comments render as a snapshot of the post-change state (e.g. in **Development**: :white_check_mark: Enabled, value `X` ) rather than describing the transition, which avoids misrepresenting value-only changes as enable/disable events.

How did you test this code?

Unit tests covering the new service, task handlers, and hook call sites (patch coverage 100%).

Manual smoke against gitlab.com, posting to flagsmith/webhooks-tetsing-1:

Issue #2 — link → enable → value change → unlink → re-link → delete
MR !3 — link → segment-override state change → identity-override state change

Screenshots

vercel · 2026-04-22T04:18:08Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview, Comment	Apr 23, 2026 2:31pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
flagsmith-frontend-preview	Ignored	Preview	Apr 23, 2026 2:31pm
flagsmith-frontend-staging	Ignored	Preview	Apr 23, 2026 2:31pm

codecov · 2026-04-22T04:23:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.42%. Comparing base (885f807) to head (1aa8b6d).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7306      +/-   ##
==========================================
+ Coverage   98.39%   98.42%   +0.02%     
==========================================
  Files        1377     1391      +14     
  Lines       51744    52219     +475     
==========================================
+ Hits        50913    51396     +483     
+ Misses        831      823       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The previous wording ("was **enabled**/was **disabled** with value X") implied the enable/disable transition was the change, so a value-only change read as an enable event that happened to already be enabled. Switch to a post-change state snapshot matching the link comment's style, e.g. "in **Development**: ✅ Enabled, value `X`". beep boop

The resource.unlinked log now fires before super().perform_destroy(), so it lands between comment.posted and webhook.deregistered. Update the assertion to match. beep boop

Zaimwa9

Couple of comments, besides the question around view versus model-hook. There is this comment I'd like to explore alternatives

Reviewer asked whether this was lazy due to a circular import. It isn't — move to module top. Update the patch target in the versioning test to patch where the name is consumed rather than where it originated. Addresses #7306 (comment) beep boop

Introduce post_gitlab_state_change_comment_for_feature_state in the GitLab services layer. It short-circuits when there's no environment or the project has no GitLabConfiguration, so the majority of projects without GitLab no longer pay for a queue entry and a configuration lookup per feature-state save. Swap both state-change dispatch sites (FeatureStateSerializerBasic, CustomEnvironmentFeatureVersionFeatureStateSerializer) to call the helper. Move the gating tests down to the helper level and simplify the serializer-level tests to assert dispatch delegation. Addresses #7306 (comment) beep boop

Pass a client timeout to the new create_issue_note and create_merge_request_note calls so a slow or unresponsive GitLab instance can't hang the web worker or task processor. Rename GITLAB_WEBHOOK_TIMEOUT to GITLAB_CLIENT_TIMEOUT_SECONDS to match the broader timeout sweep in #7307 and reduce future rebase friction — the constant is no longer webhook-specific now that every client call uses it. Addresses #7306 (comment) beep boop

The `else: return` arm in `_post_note_to_resource` was only reachable by calling the private helper with an unknown `resource_type`. In practice every caller passes a constrained `FeatureExternalResource.type`, so the branch is dead code. Remove it and re-cover the unparseable-URL path through `post_linked_comment` rather than the private helper. Addresses #7306 (comment) beep boop

…s/vcs Introduce integrations/vcs/services.py with dispatch_vcs_on_resource_create and dispatch_vcs_on_resource_destroy. Both fan out to the per-provider side effects (today only GitLab; GitHub and any future VCS will land alongside — #7315). FeatureExternalResourceViewSet.perform_create and .perform_destroy now just call the dispatchers, shedding the GitLab-specific branch, log emission, and task dispatch. The view is leaner and adding a new VCS becomes a one-module change rather than edits across view, model, and serializer hooks. Register integrations.vcs as a Django app so the docgen events crawler picks up resource.linked and resource.unlinked at their new location; regenerate the catalogue. Existing integration tests cover the dispatcher at 100%. Addresses #7306 (comment) beep boop

Merge the two None-checks for project_path and iid into a single combined guard, matching the pattern used in services/labels.py. Both checks now share one branch, so there's no longer an unreachable arm masked by `# pragma: no cover`. Addresses #7306 (comment) beep boop

post_state_change_comment reads feature_state.feature.project to look up the GitLabConfiguration; without feature__project in select_related this costs one extra query per comment dispatch. Addresses #7306 (comment) beep boop

Move apply_initial_tag and the webhook-deregister dispatch out of the AFTER_SAVE / AFTER_DELETE hooks on FeatureExternalResource and into dispatch_vcs_on_resource_create / dispatch_vcs_on_resource_destroy. The model's GitLab hooks (apply_gitlab_tag, deregister_gitlab_webhook) are gone; all GitLab side-effects for linking and unlinking now live in one place. Add deregister_gitlab_webhook_for_resource alongside the existing register_gitlab_webhook_for_resource helper so the dispatcher stays provider-agnostic and just calls named GitLab services. Call the destroy dispatcher after super().perform_destroy() so has_live_resource_for_path in the deregister task naturally excludes the just-removed row without a signature change.

emyller added 3 commits April 22, 2026 00:46

Refactor services

692b3a0

Post a comment to GitLab when linking

19c4ab7

Post another comment when unlinking

7d109b5

emyller assigned emyller and khvn26 Apr 22, 2026

github-actions Bot added the api Issue related to the REST API label Apr 22, 2026

emyller changed the title ~~Feat/gitlab links post comments~~ feat(GitLab): Post comments when linking an issue or merge request to a Flagsmith feature Apr 22, 2026

github-actions Bot added docs Documentation updates feature New feature or request and removed docs Documentation updates labels Apr 22, 2026

emyller force-pushed the feat/gitlab-links-post-comments branch from ecdc5cb to db215f3 Compare April 22, 2026 05:27

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Apr 22, 2026

emyller force-pushed the feat/gitlab-links-post-comments branch from db215f3 to fc9f9eb Compare April 22, 2026 05:35

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Apr 22, 2026

emyller and others added 2 commits April 22, 2026 02:47

Post a comment when flag state changes

c8bc6ef

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Post a comment when a flag is deleted

e91ee41

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

emyller force-pushed the feat/gitlab-links-post-comments branch from fc9f9eb to e91ee41 Compare April 22, 2026 05:48

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Apr 22, 2026

github-actions Bot added feature New feature or request and removed feature New feature or request docs Documentation updates labels Apr 22, 2026

khvn26 mentioned this pull request Apr 22, 2026

feat(GitHub): label linked issues and merge requests #7307

Open

4 tasks

Fix event order in unlink integration test

9ecc9c8

The resource.unlinked log now fires before super().perform_destroy(), so it lands between comment.posted and webhook.deregistered. Update the assertion to match. beep boop

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Apr 22, 2026

Zaimwa9 requested changes Apr 23, 2026

View reviewed changes

khvn26 added 7 commits April 23, 2026 12:17

perf(GitLab): Prefetch feature.project in state-change task

a66e8b9

post_state_change_comment reads feature_state.feature.project to look up the GitLabConfiguration; without feature__project in select_related this costs one extra query per comment dispatch. Addresses #7306 (comment) beep boop

github-actions Bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Apr 23, 2026

khvn26 requested a review from Zaimwa9 April 23, 2026 13:30

vercel Bot deployed to Preview – docs April 23, 2026 14:31 View deployment

github-actions Bot added docs Documentation updates and removed feature New feature or request docs Documentation updates labels Apr 23, 2026

Zaimwa9 approved these changes Apr 23, 2026

View reviewed changes

flagsmithdev mentioned this pull request Apr 23, 2026

chore(main): release 2.230.0 #7314

Open

khvn26 mentioned this pull request Apr 23, 2026

fix(GitLab): Orphaned feature tag after unlinking an issue or merge request #7327

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(GitLab): Post comments when linking an issue or merge request to a Flagsmith feature#7306

feat(GitLab): Post comments when linking an issue or merge request to a Flagsmith feature#7306
khvn26 merged 18 commits intomainfrom
feat/gitlab-links-post-comments

emyller commented Apr 22, 2026 •

edited by khvn26

Loading

Uh oh!

vercel Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

Zaimwa9 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

emyller commented Apr 22, 2026 • edited by khvn26 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

Screenshots

Uh oh!

vercel Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Zaimwa9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

emyller commented Apr 22, 2026 •

edited by khvn26

Loading

vercel Bot commented Apr 22, 2026 •

edited

Loading

codecov Bot commented Apr 22, 2026 •

edited

Loading