Skip to content

fix: dedupe integration list in onboarding select#7445

Merged
Zaimwa9 merged 2 commits intomainfrom
fix/dedupe-integration-list
May 7, 2026
Merged

fix: dedupe integration list in onboarding select#7445
Zaimwa9 merged 2 commits intomainfrom
fix/dedupe-integration-list

Conversation

@kyle-ssg
Copy link
Copy Markdown
Member

@kyle-ssg kyle-ssg commented May 6, 2026

integration_data flag and Constants.integrationSummaries both list some tools (e.g. GitLab), causing duplicates on the "Use Feature Flags with your favourite tools" picker. Dedupe by title.

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Fixes duplicate GitLab integration showing, due to us having one!

image

How did you test this code?

Viewed onboarding

@kyle-ssg kyle-ssg requested a review from a team as a code owner May 6, 2026 17:24
@kyle-ssg kyle-ssg requested review from Zaimwa9 and removed request for a team May 6, 2026 17:24
claude[bot]
claude Bot reviewed May 6, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment May 6, 2026 6:34pm
flagsmith-frontend-staging Ready Ready Preview, Comment May 6, 2026 6:34pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview May 6, 2026 6:34pm

Request Review

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard fix labels May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7445 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7445 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7445 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7445 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7445 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7445 Finished ✅ Results ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  43.8 seconds
commit  208eb9a
info  🔄 Run: #16562 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  27.8 seconds
commit  208eb9a
info  🔄 Run: #16562 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  42.8 seconds
commit  208eb9a
info  🔄 Run: #16562 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 7 seconds
commit  208eb9a
info  🔄 Run: #16562 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 2 seconds
commit  5962306
info  🔄 Run: #16563 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  43.4 seconds
commit  5962306
info  🔄 Run: #16563 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  41.7 seconds
commit  5962306
info  🔄 Run: #16563 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  33.3 seconds
commit  5962306
info  🔄 Run: #16563 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  11.3 seconds
commit  7ea6a4b
info  🔄 Run: #16564 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  26.5 seconds
commit  7ea6a4b
info  🔄 Run: #16564 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  54.6 seconds
commit  7ea6a4b
info  🔄 Run: #16564 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  51.4 seconds
commit  7ea6a4b
info  🔄 Run: #16564 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026 •
edited
Loading

Visual Regression

16 screenshots compared. See report for details.
View full report

matthewelwell
matthewelwell previously approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyle-ssg seems like this is a good future proofing solution, but should we also be removing the current duplicate Gitlab entry in the list?

@kyle-ssg @claude
fix: remove GitLab from aspirational integrations list
5962306 
GitLab is now a real integration via integration_data, so listing
it in Constants.integrationSummaries (the aspirational/coming-soon
list) caused it to render twice on the "Use Feature Flags with your
favourite tools" picker.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@kyle-ssg kyle-ssg force-pushed the fix/dedupe-integration-list branch from 208eb9a to 5962306 Compare May 6, 2026 18:32
@kyle-ssg
Copy link
Copy Markdown
Member Author

kyle-ssg commented May 6, 2026

Ah yep of course, done!

@kyle-ssg kyle-ssg requested a review from matthewelwell May 6, 2026 18:32
@github-actions github-actions Bot added fix and removed fix labels May 6, 2026
@kyle-ssg @claude
fix: dedupe integration list in onboarding select
7ea6a4b 
Defensive guard against future overlap between integration_data flag
values and Constants.integrationSummaries.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added fix and removed fix labels May 6, 2026
@Zaimwa9 Zaimwa9 merged commit 9d21ed6 into main May 7, 2026
29 checks passed
@Zaimwa9 Zaimwa9 deleted the fix/dedupe-integration-list branch May 7, 2026 12:27
@flagsmithdev flagsmithdev mentioned this pull request May 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@matthewelwell matthewelwell matthewelwell approved these changes

@Zaimwa9 Zaimwa9 Awaiting requested review from Zaimwa9 Zaimwa9 is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees

No one assigned

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kyle-ssg @matthewelwell @Zaimwa9