feat(SCIM): Frontend for SCIM configuration management#7528
Draft
talissoncosta wants to merge 1 commit into
Draft
feat(SCIM): Frontend for SCIM configuration management#7528talissoncosta wants to merge 1 commit into
talissoncosta wants to merge 1 commit into
Conversation
Adds the frontend UI consuming the backend SCIM management endpoints from #7512. The existing SAML tab in Organisation Settings is renamed to SSO and now hosts both SAML and SCIM as stacked sections gated by the same Enterprise plan check. Closes #7151. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #7151.
Adds the frontend UI for the SCIM configuration management endpoints landed in #7512. The existing SAML tab in Organisation Settings is renamed to SSO and now hosts both SAML and SCIM as stacked sections gated by the same Enterprise plan check.
What's in:
common/services/useScimConfiguration.ts) —get/create/delete/regenerate-token, scoped per organisation, cache-tagged for invalidation.ScimSectioncomponent handles three states: loading, empty (404 from the server is the empty signal), and configured (showscreated_at,token_rotated_at, copyablebase_url, plus Regenerate / Delete actions).ScimTokenModaldisplays the bearer token exactly once on create or regeneration. Token is passed straight from the mutation result into the modal as a prop — never cached in Redux, never refetched.PlanBasedBannerat the SSO container level. SAML's previously-inline banner has been lifted out so both sections share one gate (no duplicate upgrade prompts).SSOTabcontainer (tabs/SSOTab.tsx) composes SAML + SCIM as sibling sections.?tab=samlto?tab=sso(existing?tab=samlbookmarks land on the default tab).SCIMadded to thePaidFeatureenum andfeatureDescriptions; gated at thescale-upplan (mirrors SAML).EmptyStatecomponent so it sits visually as a peer to the SAML configurations block.The configuration's
base_urlcomes back from the server (built viarequest.build_absolute_uri(reverse("scim:root"))inflagsmith-private) — no client-side URL building needed, unlike SAML's ACS URL.How did you test this code?
Manual end-to-end on a local dev environment with
--extra sciminstalled:token_rotated_atupdates after close./organisation/{id}/settings?tab=ssoopens the SSO tab;?tab=samllands on the default tab.Plus
npm run typecheckandnpx eslint --fixon all modified files — no new errors introduced (pre-existing type errors confirmed viagit stash+ retry to be unrelated to this change).