Skip to content

test: Fix test_unit_routers.py #7530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khvn26 merged 2 commits into from
May 19, 2026
+18 −19
Merged

test: Fix test_unit_routers.py #7530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b90a1fd
fix: test_unit_routers.py for ci/cd
SahilJat May 18, 2026
6d6282a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions api/tests/unit/app/test_unit_app_routers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
from unittest import mock

import pytest
from django.db import models
from django.db.models.options import Options

from app import routers

Expand All @@ -16,14 +19,13 @@ def test_analytics_router_db_for_read__given_app_label__returns_expected_db(
expected_db: str | None,
) -> None:
# Given
class AnalyticsModel(models.Model):
class Meta:
app_label = given_app_label

mock_model = mock.MagicMock(spec=models.Model)
mock_model._meta = mock.MagicMock(spec=Options)
mock_model._meta.app_label = given_app_label
router = routers.AnalyticsRouter()

# When
db = router.db_for_read(AnalyticsModel)
db = router.db_for_read(mock_model)

# Then
assert db == expected_db
Expand All @@ -41,14 +43,13 @@ def test_analytics_router_db_for_write__given_app_label__returns_expected_db(
expected_db: str | None,
) -> None:
# Given
class MyModel(models.Model):
class Meta:
app_label = model_app_label

mock_model = mock.MagicMock(spec=models.Model)
mock_model._meta = mock.MagicMock(spec=Options)
mock_model._meta.app_label = model_app_label
router = routers.AnalyticsRouter()

# When
db = router.db_for_write(MyModel)
db = router.db_for_write(mock_model)

# Then
assert db == expected_db
Expand All @@ -67,18 +68,16 @@ def test_analytics_router_allow_relation__given_app_labels__returns_expected(
expected: bool | None,
) -> None:
# Given
class MyModel1(models.Model):
class Meta:
app_label = model1_app_label

class MyModel2(models.Model):
class Meta:
app_label = model2_app_label

mock_instance1 = mock.MagicMock(spec=models.Model)
mock_instance1._meta = mock.MagicMock(spec=Options)
mock_instance1._meta.app_label = model1_app_label
mock_instance2 = mock.MagicMock(spec=models.Model)
mock_instance2._meta = mock.MagicMock(spec=Options)
mock_instance2._meta.app_label = model2_app_label
router = routers.AnalyticsRouter()

# When
result = router.allow_relation(MyModel1(), MyModel2())
result = router.allow_relation(mock_instance1, mock_instance2)

# Then
assert result == expected
Expand Down
Loading