fix: detect multivariate differences between environments#7635
Open
10done wants to merge 2 commits into
Open
Conversation
|
@10done is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Code Review
This pull request introduces a utility function hasMultivariateChange to detect differences in multivariate feature allocations when comparing environments and features, along with corresponding unit tests. The feedback suggests defensively converting multivariate_feature_option to a number during normalization to prevent potential NaN values from causing unstable sorting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Fixes #7619
hasMultivariateChange()to comparemultivariate_feature_option+percentage_allocationper environmentCompareEnvironmentsfor changed/unchanged classification and row fade behaviorCompareFeaturesso MV-only differences are not shown as identicalcompare-multivariate-utils.test.tsHow did you test this code?
I have tested the code manually and added screenshots below and also added unit tests for the same.
Before
No flag differences / rollout_test in Unchanged (Dev 0% vs Prod 100%).
After
rollout_test under Changed Flags.