ci: Run flagsmith-private test suites inline on 0.8.0#7665
Closed
khvn26 wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7665 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 1444 1444
Lines 55083 55087 +4
=======================================
+ Hits 54273 54277 +4
Misses 810 810 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bump flagsmith-private to 0.8.0, which now bundles auth_controller alongside rbac and workflows_logic, and pull its rbac, workflows_logic, auth_controller and saml suites into the inline `make test` run so they run again like before the repos were split out. - Drop the auth-controller extra and git source; it ships in flagsmith-private 0.8.0, so integrate-private-tests no longer clones flagsmith-auth-controller separately. - integrate-private-tests pulls each app's tests from flagsmith-private at the installed wheel's tag and drops them under tests/ so they inherit Core API's tests/conftest. - scim and release_pipelines are not pulled: scim's compliance tests need an SCIM_SERVICE_PROVIDER config that conflicts with Core API's own scim tests (django-scim2 caches it globally), and release_pipelines has an order-dependent assertion that only holds in isolation. Both run in flagsmith-private's CI. beep boop
8eb3842 to
4a1db37
Compare
a3be387 to
4a1db37
Compare
4 tasks
Contributor
|
Superseded by #7667 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to Flagsmith/flagsmith-private#177.
Follows on from #7656, which consolidated
rbacandworkflows_logicintoflagsmith-privateand runs their suites inline viamake test. This extends the same pattern toflagsmith-private0.8.0, which also bundlesauth_controller, so the private suites run inline against Core API again.flagsmith-privateto>=0.8.0. It now shipsauth_controller, so drop theauth-controllerextra and its git source;integrate-private-testsno longer clonesflagsmith-auth-controllerseparately.integrate-private-testspulls each app's tests (rbac,workflows_logic,auth_controller,samlunit + integration) fromflagsmith-privateat the installed wheel's tag and drops them undertests/so they inherit Core API'stests/conftestand run inline withmake test..gitignorethe cloned repo and the stagedtests/*_testsdirectories.scimandrelease_pipelines_logicare deliberately left out for now and continue to run in flagsmith-private's own CI:scim: its compliance tests require anSCIM_SERVICE_PROVIDERconfig (notably dropping the request-basedBASE_LOCATION_GETTER) that directly conflicts with Core API's owntests/integration/scimtests, and django-scim2 reads that setting once at import — so both suites cannot share one pytest session.release_pipelines_logic: one test asserts a non-deterministic email ordering that only holds in isolation; it fails when collected alongside the full Core API suite.Both gaps are tracked in Flagsmith/flagsmith-private#177.
How did you test this code?
Locally, against the Compose Postgres, with
--extra dev --extra privateinstalled:make integrate-private-teststo stage the suites.Ran the staged suites under Core API's pytest config (
--ds=app.settings.test,--import-mode=importlib):Result: 343 passed.