fix: Improve ButterBar text contrast on banners#7684
Merged
Conversation
|
@AAshGray is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
talissoncosta
requested changes
Jun 4, 2026
Contributor
talissoncosta
left a comment
There was a problem hiding this comment.
Thanks for the contribution! 🙏 Solid fix, reusable helper, WCAG luminance, the right 0.179 threshold, nicely scoped. The two notes above are minor and non-blocking. Looking forward to merging once they're sorted. 🎉
Contributor
Author
|
Thanks for the clear explanations, let me know if there's anything else! 😄 |
talissoncosta
approved these changes
Jun 4, 2026
Contributor
talissoncosta
left a comment
There was a problem hiding this comment.
Looks great! thanks for your contribution. 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Contributes to #7604
Changes
Utils.getContrastColour(...)tofrontend/common/utils/utils.tsxfrontend/web/components/ButterBar.tsxto useUtils.getContrastColour(...)for environment banner text colour instead of hardcoding whiteHow did you test this code?
banner_colourand banner text