fix(Tagging): TagType evaluated incorrectly in database queries#7877
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7877 +/- ##
==========================================
- Coverage 98.61% 98.61% -0.01%
==========================================
Files 1486 1486
Lines 58301 58300 -1
==========================================
- Hits 57495 57494 -1
Misses 806 806 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
Skipped testsfirefox › tests/initialise-tests.pw.ts › Signup › Create Organisation and Project @oss Details
|
Visual Regression17 screenshots compared. See report for details. |
khvn26
left a comment
There was a problem hiding this comment.
LGTM!
Any other enums we should take care of? (doesn't have to be this PR, but having an issue would be nice if anything's left)
Good call. Found a couple: #7878 There's a bunch of enums — not |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #7433
Fixes a bug in which tag-based querying won't bring results because SQL is evaluated with non-str object representation, e.g.
WHERE type = '<TagType.STALE>'.Normalise
TagTypeinterfacing:TextChoicesprovides reliable ergonomicsHow did you test this code?
Running tests.