WIP | user auth#209
Closed
bootstraponline wants to merge 5 commits into
Closed
Conversation
Macarse
reviewed
Jun 12, 2018
| private class BillingQuotaProject internal constructor() : GoogleClientRequestInitializer { | ||
| override fun initialize(request: AbstractGoogleClientRequest<*>) { | ||
| // TODO: read project id from config | ||
| request.requestHeaders.set("X-Goog-User-Project", "delta-essence-114723") |
Contributor
There was a problem hiding this comment.
"delta-essence-114723" is your firebase project id?
Contributor
Author
There was a problem hiding this comment.
yeah, this is WIP. It'll be read from the config before merging.
This was referenced Jun 12, 2018
Contributor
Author
|
To simplify the user experience, we're going to support service account authentication only. Service accounts are the official recommended way of testing in CI. There isn't a strong value proposition for adding an additional auth mechanism that doesn't work in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #196