fix(engine): strip tracking params from result links - #32
Merged
Conversation
UrlNormalizer stripped utm_*/fbclid/etc. but only for the dedup key; the aggregator stored the raw upstream URL, so the link a user clicks still carried trackers. Add UrlNormalizer.stripTracking (lossless apart from the tracker params: keeps scheme/host case, path, trailing slash, fragment, param order) and surface it as the result URL. Covers the in-app results and the served web page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of the desktop fix (SearchMob-Desktop#33). Result links were only stripped of trackers for de-duplication, not for the link the user actually clicks.
Problem
UrlNormalizer.normalizeremovesutm_*,fbclid,gclid, ... but theAggregatorused it only as the dedup key and stored the rawitem.urlfor display (Aggregator.kt). So the in-app results and the served web page kept trackers in their links.Fix
UrlNormalizer.stripTracking(url): removes the same tracker set but preserves the URL otherwise (scheme/host case, path, trailing slash, fragment, surviving param order), so the clicked link stays faithful.Aggregator.ranknow storesUrlNormalizer.stripTracking(item.url);normalizeremains the lossy dedup key.Verification
./gradlew :app:testDebugUnitTest—UrlNormalizerTest6/6 (3 new),AggregatorTest7/7,EngineSupersedesTest2/2, all green.🤖 Generated with Claude Code