Skip to content

Fix terminal URL activation gesture - #137

Merged
FloSch62 merged 1 commit into
mainfrom
fix/issue-134-terminal-url-click-modifier
Aug 17, 2026
Merged

Fix terminal URL activation gesture#137
FloSch62 merged 1 commit into
mainfrom
fix/issue-134-terminal-url-click-modifier

Conversation

@FloSch62

Copy link
Copy Markdown
Owner

Summary

  • apply the configured terminal link activation gesture to web URLs as well as file paths
  • keep non-matching clicks available for terminal text selection
  • clear incidental selections after a URL is deliberately opened
  • rename the setting label to Open terminal links and document that it covers both link types

Why

Terminal web URLs were handled directly by the xterm web-links callback, bypassing the modifier checks used by terminal file links. As a result, an ordinary click could open a URL while the default file-link behavior required Alt + left click.

This makes URL and file-link interactions consistent and preserves normal click and double-click text selection.

Closes #134.

Validation

  • pnpm exec vitest run unit/client/terminal-file-links.test.ts — 28 tests passed
  • full unit suite — 931 tests passed, 3 skipped
  • pnpm typecheck
  • pnpm lint

@FloSch62
FloSch62 marked this pull request as ready for review August 17, 2026 08:10
@FloSch62
FloSch62 merged commit 977dc2a into main Aug 17, 2026
5 checks passed
@FloSch62
FloSch62 deleted the fix/issue-134-terminal-url-click-modifier branch August 17, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement solution for issue #116 to URLs

1 participant