Reject complex SE2 UKF inputs - #5005
Merged
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 7, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
SE2UKFaccepted complex-valued dual-quaternion states, noise distributions, and measurements whenever their shapes, finiteness, and real-valued geometric checks happened to pass.For example, the measurement
[1+0j, 0, 1j, 0]has a valid unit rotation part and finite entries, so the existing validator accepted it. The identity update then propagated the imaginary translation into an otherwise real filter state; with the default state and0.1 Imeasurement covariance, the posterior translation becomes approximately0.909i.Complex dual-quaternion coordinates are outside the real SE(2) state space represented by this filter.
Fix
Regression coverage
ValueErrorand leaves the posterior mean and covariance unchangedValidation
mainhead and is zero commits behindse2_ukf.pyand one focused regression-test file