Stabilize discrete-state prior normalization - #5432
Merged
Merged
Conversation
FlorianPfaff
enabled auto-merge (squash)
August 25, 2026 12:19
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
discrete_forward_backwardandimm_forward_backwardBug
A valid prior such as
[float_max, float_max / 2]previously overflowed when summed. The resultinginfdenominator collapsed the normalized vector to zeros, causing filtering to fail with a spurious no-mass error.Fix
Scale finite non-negative weights by their maximum before summing and normalizing. This also improves robustness for extremely small finite weights.