fix(ci): preserve isolated runner cleanup time#164
Conversation
|
Warning Review limit reached
Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Chunk / Goal
WS-CI-001-01R1 repairs the valid CodeRabbit timeout finding posted on merged PR #163. Isolated child runners must time out before their enclosing GitHub jobs so repository-owned process termination and database cleanup retain operational headroom.
Human-Approved Intent
The user explicitly asked to fix the CodeRabbit comment. This is a bounded post-merge repair based on trusted
main; WS-CI-001-02 remains inactive.What Changed
Why / Alternatives
GitHub could previously hard-cancel the job before the isolated runner completed cleanup. Increasing job budgets was rejected because the child values were already far above observed runtimes. The configured 600s/300s gaps are operational headroom, not guaranteed cleanup durations because setup also consumes job time.
Scope Control
No application code, schema, dependency, test selection, coverage threshold, required check, permission, authentication, authorization, product lifecycle, or merge authority changed.
Commands Run
Result Summary
The isolated runners now fail first and retain operational cleanup headroom before GitHub job deadlines. Existing fail-closed propagation remains intact.
Acceptance Criteria
Test Delta
One existing workflow-integrity test was strengthened. No tests or assertions were removed, skipped, or weakened.
Internal Review
Senior engineering, QA/test, security/auth, product/ops, architecture, CI integrity, docs, reuse/dedup, and test-delta all passed. Documentation-relevant tracks additionally confirmed the chunk-map and evidence-only corrections.
CI / Gate Integrity
Coverage floors, full-suite selection, fixed artifact fan-in,
Backend / test, failure propagation, and human merge authority are unchanged.Human Review Focus
Confirm timeout values remain sufficient for observed workloads, strictly below job budgets, and preserve child termination and owned database cleanup.
Trust Bundle
.agent-loop/initiatives/WS-CI-001-backend-ci-acceleration/reviews/WS-CI-001-01R1-pr-trust-bundle.mdMerge intent:
.agent-loop/merge-intents/WS-CI-001-01R1.jsonHuman approval is required before merge.