-
Notifications
You must be signed in to change notification settings - Fork 6
feat(auth): hard-cut project diagnostic reads #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
abiorh-claw
merged 6 commits into
main
from
codex/ws-auth-001-11c1-setup-diagnostic-reads
Jul 28, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f49bccb
feat(auth): hard-cut project diagnostic reads
Abiorh001 be3e214
test(auth): align active action expectations
Abiorh001 6db285d
fix(auth): address diagnostic read review
Abiorh001 b389baf
test(auth): align hosted context projection
Abiorh001 e0109fb
test(auth): prove local diagnostic authority
Abiorh001 8e2d249
Merge remote-tracking branch 'origin/main' into codex/ws-auth-001-11c…
Abiorh001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
...ream-authorization-service/reviews/WS-AUTH-001-11C1-external-review-response.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # WS-AUTH-001-11C1 External Review Response | ||
|
|
||
| ## Comments addressed | ||
|
|
||
| - Corrected the verifier-outage sentence in the chunk contract. | ||
| - Wrapped the three repository joins identified by CodeRabbit. | ||
| - Bounded each diagnostic collection lock and response to the newest 100 rows, | ||
| preserving deterministic newest-first ordering and matching the established | ||
| retained-diagnostic cap. | ||
| - Strengthened `ProjectDiagnosticReadResourceContext`: snapshot hashes must be | ||
| canonical SHA-256 digests, and existing non-collection targets must carry the | ||
| paired snapshot identifier and hash. Collections remain bound by their exact | ||
| ordered row-set digest. | ||
| - Narrowed the setup-run branch before accessing setup-run-only fields. | ||
| - Replaced the fixture's implicit submitter grant with an explicit, idempotent | ||
| Access Administrator bootstrap helper. | ||
| - Updated the two stale full-suite active-action expectations reported by the | ||
| first hosted Backend run. | ||
| - Updated the stale real-API E2E Project Manager action projection reported by | ||
| the second hosted Backend run; the production response already contained the | ||
| correct six newly active actions. | ||
| - Split the E2E policy-bundle helper's legacy mutation token from its locally | ||
| granted diagnostic-reader token after the third hosted run correctly denied | ||
| issuer-role-only access to the migrated GET routes. | ||
|
|
||
| ## Comments deferred or rejected | ||
|
|
||
| - The post-authorization `target is None` guard remains a sanitized invariant | ||
| failure. Replacing it with a concealed 404 would hide a kernel defect if AUTH | ||
| ever allowed facts declaring `target_exists=False`; the normal missing-target | ||
| path is already concealed by the authorization dependency before this guard. | ||
| - The six reads remain serialized over actor, identity-link, and matched-grant | ||
| rows. That locking is required by the approved anti-stale and concurrent- | ||
| revocation contract. Removing it based only on a speculative contention note | ||
| would weaken the security property. The bounded child collection limits the | ||
| newly identified unbounded-lock risk. | ||
| - CodeRabbit's generic PR-description and docstring-coverage warnings do not | ||
| identify a missing public contract or undocumented production callable. The | ||
| PR links the repository trust bundle; production additions carry docstrings, | ||
| and repository CI—not the bot's heuristic—owns coverage thresholds. | ||
|
|
||
| ## Human decisions needed | ||
|
|
||
| None. Human merge approval remains required after exact-head hosted checks pass. | ||
|
|
||
| ## Commands rerun | ||
|
|
||
| - `uv run ruff check app tests scripts` | ||
| - Focused audit, authorization-context, diagnostic resource validation, | ||
| bounded-lock SQL, and six-action composer tests: 13 passed. | ||
| - Focused live PostgreSQL diagnostic-route proof could not start without | ||
| `WORKSTREAM_TEST_DATABASE_URL`; the corresponding hosted lane remains required. | ||
| - Hosted Backend, Agent Gates, and CodeRabbit: required again on the final head. | ||
|
|
||
| ## Remaining risks | ||
|
|
||
| - A diagnostic list intentionally returns at most the newest 100 records; an | ||
| older exact record remains addressable through its individually authorized | ||
| read route. | ||
| - Hosted semantic lanes, API E2E, and coverage gates must pass on the final head. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.