WS-XINT-003-02C: add REV authorization readiness - #255
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe change registers four planned REV actions and six service identities, adds migration ChangesREV authorization readiness
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant AuthorizationCatalogue
participant Alembic0049
participant PostgreSQL
participant ServiceActorAPI
AuthorizationCatalogue->>Alembic0049: provide REV action and identity definitions
Alembic0049->>PostgreSQL: register values and replace constraints
ServiceActorAPI->>PostgreSQL: provision six fixed review identities
PostgreSQL-->>ServiceActorAPI: return identities without grants
Alembic0049->>PostgreSQL: check evidence and identity usage on downgrade
PostgreSQL-->>Alembic0049: allow or reject rollback
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
@.agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/ACTIVATION_CUSTODY.md:
- Around line 94-99: Update the WS-AUTH-001-REV-CUSTODY description to clarify
that AUTH_REV_05 through AUTH_REV_12 remain in the runtime ActionOwner catalogue
for the original 19 actions. State that the XINT-003 values represent planning
or future activation custody only, pending a later change that replaces the
runtime owners, and remove the claim that the seven historical REV owner enum
values are removed.
In
@.agent-loop/initiatives/WS-XINT-003-rev-auth-end-to-end/chunks/WS-XINT-003-02C-auth-catalogue-principal-readiness.md:
- Around line 5-6: Update the status line in the chunk document to indicate that
implementation is complete and the internal review has passed, with only hosted
CI evidence pending. Remove the outdated “Proposed for L1 plan review before
implementation” wording while preserving the surrounding implementation contract
text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 7119331c-d010-4bfe-b9f6-0da1003993cb
📒 Files selected for processing (16)
.agent-loop/initiatives/WS-AUTH-001-workstream-authorization-service/ACTIVATION_CUSTODY.md.agent-loop/initiatives/WS-XINT-003-rev-auth-end-to-end/ACTION_CUSTODY.md.agent-loop/initiatives/WS-XINT-003-rev-auth-end-to-end/REVIEW_LOG.md.agent-loop/initiatives/WS-XINT-003-rev-auth-end-to-end/STATUS.md.agent-loop/initiatives/WS-XINT-003-rev-auth-end-to-end/chunks/WS-XINT-003-02C-auth-catalogue-principal-readiness.md.agent-loop/initiatives/WS-XINT-003-rev-auth-end-to-end/reviews/WS-XINT-003-02C-internal-review.md.agent-loop/initiatives/WS-XINT-003-rev-auth-end-to-end/reviews/WS-XINT-003-02C-pr-trust-bundle.mdbackend/alembic/versions/0049_rev_auth_readiness.pybackend/app/modules/actors/service_identities.pybackend/app/modules/authorization/catalogue.pybackend/tests/test_alembic.pybackend/tests/test_auth.pybackend/tests/test_authorization.pydocs/operations_authorization_service.mddocs/spec_authorization_service.mddocs/spec_review_lifecycle.md
2 participants
PR Trust Bundle: WS-XINT-003-02C
Intent and scope
Register the complete unavailable REV authorization vocabulary and exact fixed
service principals before REV implementation begins. This chunk adds four
planned actions, six closed identities, six static matrix rows, and database
parity only.
Design and safety
review.reconcile.run;future REV code must derive their modes server-side.
protected by
FUTURE_INTENT_REQUIRED_ACTIONS.after direct/linked action evidence or use of any new identity.
Exclusions
No REV queue, lease, finding, decision, revision, recovery, projection,
lifecycle behavior, PREP protocol, route, worker, provider I/O, or action
activation is included.
Evidence
and docs review: pass; valid findings resolved.
Hosted GitHub Actions must provide PostgreSQL schema/API execution, full-suite
coverage (repository 78 percent and changed authorization/actor subsystems 90
percent), and the final exact-head merge evidence.
Human review focus
Verify the four action/permission/owner triples, the six identity-to-action
rows, the exact 0048-to-0049 constraint transformation, and that no availability
or product behavior changed.
Summary by CodeRabbit
New Features
Documentation
Bug Fixes