Skip to content

Apply FORBID_STORING_PASS_PHRASE OrgRule to add_key.htm frame #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2021
Merged

Apply FORBID_STORING_PASS_PHRASE OrgRule to add_key.htm frame #3757

merged 2 commits into from
Jun 16, 2021

Conversation

@rrrooommmaaa
Copy link
Contributor

@rrrooommmaaa rrrooommmaaa commented Jun 16, 2021 •
edited
Loading

This PR ensures that adding a private key obeys the FORBID_STORING_PASS_PHRASE OrgRule

close #3756

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@rrrooommmaaa rrrooommmaaa marked this pull request as ready for review June 16, 2021 07:28
tomholub
tomholub approved these changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@tomholub tomholub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomholub tomholub merged commit fff9d5f into master Jun 16, 2021
@tomholub tomholub deleted the issue-3756-forbid-storing-pass-phrase-for-add-key branch June 16, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomholub tomholub tomholub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apply FORBID_STORING_PASS_PHRASE OrgRule to add_key.htm frame

3 participants

@rrrooommmaaa @tomholub