bind message gateway id #4353
bind message gateway id #4353
Conversation
Originally posted by @tomholub in #4284 (comment) Should I keep this PR draft meanwhile? |
|
yup 👍 |
|
Actually, the whole time we had FES 2022-05 running, which is the latest version. Have you tried this smaller PR against a live instance, is it giving you any trouble? |
|
If you test it against a live instance and it works as intended, you can mark it as ready for review. Thanks! 👍 |
tomholub
left a comment
tomholub
left a comment
There was a problem hiding this comment.
Looks good - see comment below
| } | ||
| } | ||
| if (msg.externalId) { | ||
| this.view.acctServer.messageGatewayUpdate(msg.externalId, msgSentRes.id).catch(Catch.reportErr); |
There was a problem hiding this comment.
I think we can await this, and put it just after draftDelete. I suppose we could make the two calls in parallel if we want to speed it up a little bit.
I tried that in early February. I don't quite get it -- should I log in as |
ok - that was likely on older instance
correct - https://fes.flowcrypt.com will be used on |
rrrooommmaaa
force-pushed
the
issue-4269-message-gateway-update-1
branch
from
35ce6e1 to
0420488
Compare
…Crypt/flowcrypt-browser into issue-4269-message-gateway-update-1
This PR binds message gateway id for pwd-encrypted messages
close #4269
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):