Skip to content

prefer cleartext signed message #4988#4992

Merged
rrrooommmaaa merged 2 commits intomasterfrom
issue-4988-prefer-cleartext
Mar 4, 2023
Merged

prefer cleartext signed message #4988#4992
rrrooommmaaa merged 2 commits intomasterfrom
issue-4988-prefer-cleartext

Conversation

@rrrooommmaaa
Copy link
Copy Markdown
Contributor

@rrrooommmaaa rrrooommmaaa commented Mar 4, 2023

This PR creates a cleartext signed message in MsgUtil.sign if detached=false

close #4988

Tests (delete all except exactly one):

  • Tests added and updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@rrrooommmaaa rrrooommmaaa marked this pull request as ready for review March 4, 2023 08:28
@rrrooommmaaa rrrooommmaaa requested a review from sosnovsky as a code owner March 4, 2023 08:28
@rrrooommmaaa rrrooommmaaa enabled auto-merge (squash) March 4, 2023 08:29
@rrrooommmaaa rrrooommmaaa merged commit e34fa7f into master Mar 4, 2023
@rrrooommmaaa rrrooommmaaa deleted the issue-4988-prefer-cleartext branch March 4, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

user question: signed message is in encrypted format

2 participants

@rrrooommmaaa @sosnovsky