Skip to content

#5317 Add custom authentication config to local store #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 23, 2023
Merged

#5317 Add custom authentication config to local store #5371

merged 15 commits into from
Aug 23, 2023

Conversation

@martgil
Copy link
Collaborator

@martgil martgil commented Aug 18, 2023 •
edited by sosnovsky
Loading

This PR Adds a custom authentication data configuration to a local store.

close #5317

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner August 18, 2023 09:49
@martgil martgil marked this pull request as draft August 18, 2023 09:49
@martgil martgil changed the title #5317 add custom authentication config to local store #5317 Add custom authentication config to local store Aug 18, 2023
@martgil martgil marked this pull request as ready for review August 22, 2023 02:27
@martgil martgil marked this pull request as draft August 22, 2023 02:32
@martgil martgil marked this pull request as ready for review August 22, 2023 03:22
@martgil
Copy link
Collaborator Author

martgil commented Aug 22, 2023

@sosnovsky ready for review. thank you.

sosnovsky
sosnovsky reviewed Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

sosnovsky
sosnovsky previously approved these changes Aug 22, 2023
View reviewed changes
@sosnovsky sosnovsky enabled auto-merge (squash) August 22, 2023 10:49
@martgil martgil requested a review from sosnovsky August 23, 2023 08:52
@martgil
Copy link
Collaborator Author

martgil commented Aug 23, 2023

@sosnovsky ready for review again. thank you.

sosnovsky
sosnovsky approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky merged commit c4cc798 into master Aug 23, 2023
@sosnovsky sosnovsky deleted the issue-5317-add-authentication-config-to-local-store branch August 23, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add custom authentication config to local store

3 participants

@martgil @sosnovsky