#2768 Improve email rendering#2769
Merged
sosnovsky merged 11 commits intoJul 17, 2026
Merged
Conversation
martgil
marked this pull request as draft
June 30, 2026 07:14
martgil
marked this pull request as ready for review
June 30, 2026 10:02
This comment was marked as outdated.
This comment was marked as outdated.
sosnovsky
reviewed
Jun 30, 2026
sosnovsky
reviewed
Jul 1, 2026
…thread-view-email-rendering
martgil
marked this pull request as draft
July 3, 2026 11:06
martgil
marked this pull request as ready for review
July 9, 2026 07:51
Collaborator
Author
|
Hi @sosnovsky - This one is ready for a review. Thank you! |
sosnovsky
reviewed
Jul 9, 2026
Comment on lines
+120
to
+123
| // SanitizeHtml replaces > with > and < with < so need to convert them back | ||
| self.quote = try await (Core.shared.sanitizeHtml(html: quote)) | ||
| .replacingOccurrences(of: ">", with: ">") | ||
| .replacingOccurrences(of: "<", with: "<") |
Collaborator
There was a problem hiding this comment.
with this change, attacker can put > and < in the original message content, and it'll be converted to > and < on message render.
for example, attacker sends message with <img src=x onerror="alert('xss')">, it passes our html sanitizer and converted to <img src=x onerror="alert('xss')">
Collaborator
|
Hi @martgil, have you tested my latest update here - does it work well for you? If so, I'll merge it |
Collaborator
Author
|
Yes @sosnovsky - I have completed testing the latest update and it works well on my side. |
sosnovsky
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves HTML email rendering on thread view and other related files.
close #2768
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):