chore(expert): tool-permissions review follow-ups (comments + generic JsonViewer)#7730
Merged
Merged
Conversation
added 2 commits
July 4, 2026 16:50
Shorten the /mcp/tools and curatePlatformTool doc blocks, drop the stale TODO in the catalog catch block while keeping the 401 rationale, and trim the ToggleButtonGroup size prop comment. Closes #7728
Move JsonViewer out of the expert message tree into frontend/src/components so it can be reused, and update its only consumer (ToolApprovalCard). Move its safeStringify helper into the shared strings composable with a unit test. Closes #7729
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7730 +/- ##
==========================================
- Coverage 75.37% 75.37% -0.01%
==========================================
Files 425 425
Lines 22518 22518
Branches 5945 5945
==========================================
- Hits 16974 16973 -1
- Misses 5544 5545 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cstns
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanups agreed during review of #7639 (human-in-the-loop tool permissions). No behaviour change.
Comments cleanup (#7728)
/mcp/toolshandler andcuratePlatformTooldoc blocks inforge/ee/routes/expert/index.js.TODO: decide with the team whether this belongs on the branchin the catalog catch block, keeping the rationale for why an upstream 401/403 must not be forwarded as our own 401.sizeprop comment inToggleButtonGroup.vue.Generic JsonViewer (#7729)
JsonViewer.vueout of the expert message tree intofrontend/src/componentsso it can be reused (its only consumer,ToolApprovalCard, is updated to the new import).safeStringifyhelper into the shared strings composable (frontend/src/composables/strings/String.js) and add a unit test.Testing
safeStringifyunit tests pass.Closes #7728
Closes #7729