Fix navigation for custom editor paths#7784
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7784 +/- ##
==========================================
- Coverage 75.05% 75.04% -0.02%
==========================================
Files 429 429
Lines 22714 22777 +63
Branches 6012 6036 +24
==========================================
+ Hits 17048 17092 +44
- Misses 5666 5685 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andypalmi
left a comment
There was a problem hiding this comment.
Looks good. One thing to fix before merge:
UrlHelper.tsis missing a trailing newline, which fails theeol-lastlint rule.
Non-blocking suggestion: useUrlHelper has no reactive state or lifecycle, so it's a plain function factory rather than a composable. Might fit better under utils/ alongside the other URL helpers.
that's a good observation! I'm still undecided if we should keep both composables and utils or merge them into one |
Description
extends on #7783
Adds a useUrlHelper composable (safeOrigin, originsMatch) that wraps new URL().origin in a try/catch so a malformed URL can't throw and break message handling.
Wires it into the two places that compare postMessage origins:
Related Issue(s)
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel