[7827] Improve UI for device status#7848
Conversation
|
Love it. It is exactly how I hoped (personal opinion)
I think that is fine for now. Moving forward, for me, the separate pills/badges (where there is more space) is more useful for "at a glance" info. One thing I would probably want tho is the colour of the device overview pill to reflect online/offline status.
Similar to last point, where there is more space, it feels (to me) better to make information more glanceable. I think the task here is to align with whatever we do to the header. Perhaps a single follow up issue to update the top "Last Seen" + "Last Known Status" and device details to utilise the online/offline status for colour and appearance would be in order? |
|
Hey @Steve-Mcl thank you for your thoughts! I went ahead and created Make device detail page and list summary bars consistent with new online status design #7876 as a follow up around these points. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7848 +/- ##
==========================================
- Coverage 75.60% 75.57% -0.04%
==========================================
Files 432 432
Lines 23046 23051 +5
Branches 6111 6114 +3
==========================================
- Hits 17424 17420 -4
- Misses 5622 5631 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| application: item.Application ? app.db.views.Application.applicationSummary(item.Application) : null, | ||
| deviceCount: parseInt(item.deviceCount) || 0, | ||
| devices: item.Devices ? item.Devices.map(app.db.views.Device.device) : [], | ||
| devices: group.Devices ? group.Devices.map(app.db.views.Device.device) : [], |
There was a problem hiding this comment.
item is group.toJSON(), so item.Devices are plain objects. device.status (a Sequelize virtual) is undefined on those, which drops onlineStatus and fails the required schema check. group.Devices are the real instances, so it resolves.
| <template> | ||
| <div | ||
| v-ff-tooltip:left="tooltip" | ||
| class="forge-badge" |
There was a problem hiding this comment.
we should use a different kind of pointer when hovering
|
created #7879 as a follow up |
|
Also, device sorting by status seems to be way off |
Discussed in slack, since |
Description
Routes the new computed device status to
onlineStatus(online/offline/never-seen). Collapses the device tables' "Last Seen" + "Last Known Status" columns into a single "Status" pill with last-seen and last-reported state in a tooltip.Live update changes
Live status updates piggyback on the team-channel state message, which now carries
onlineStatus.We only ever push
onlinefromhandleStatus, which runs when a device checks in so we send it on any reconnect that flips it back. We can't pushofflinebecause goingofflineis silence, soofflineis computed fromlastSeenAton page load instead.Items to note
Related Issue(s)
Resolves #7827
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel