[TASK] Fix false positives with bulk request error detection#20
Merged
kdambekalns merged 1 commit intomasterfrom Mar 7, 2014
Merged
[TASK] Fix false positives with bulk request error detection#20kdambekalns merged 1 commit intomasterfrom
kdambekalns merged 1 commit intomasterfrom
Conversation
The simple strpos() check used does not work, the response contains a boolean flag named "error", so the check always fired. Note: this is probably a ES 1.0 change.
Member
Author
|
Oh, sorry that this contains unrelated cleanup as well ;) |
Member
Author
|
@robertlemke Please check this one as well. |
kdambekalns
added a commit
that referenced
this pull request
Mar 7, 2014
[TASK] Fix false positives with bulk request error detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simple strpos() check used does not work, the response contains a
boolean flag named "error", so the check always fired.
Note: this is probably a ES 1.0 change.