TASK: Update travis.yml, remove "typo3", declare dependencies#217
Conversation
We are stuck with ElasticSearch for code, but this adjusts the spelling in comments where it makes sense.
| indexName: typo3cr | ||
|
|
||
| # API. name of the Elasticsearch index to use. Will create many indices prefixed by this indexName. | ||
| indexName: neoscr |
There was a problem hiding this comment.
This one is breaking when you make your own mapping adjustments, like we did here: https://github.com/Flowpack/Flowpack.SearchPlugin/pull/26/files#diff-d06e40a2a4877cacd0ccde3ab14e8588R23
So we need some migration instructions for that.
There was a problem hiding this comment.
Does the (new) PR description work for you? I'd also make sure a release hints at the needed changes. Or should we stay with the "old name" to be on the safe side?
And… didn't we change that name elsewhere already anyways? Hm…
There was a problem hiding this comment.
Good catch @daniellienert. These changes doesn't really justify a breaking change IMO, so maybe keep it for now and change next time a major version is needed? e.g. open a pull request this specifically for it and label it "Next major"
There was a problem hiding this comment.
Basically this PR is for master, and no planned release from master currently, we have branch 1.2 (stale), 2.0 and 3.0 (active) for stable release, so no object to merge this in master
There was a problem hiding this comment.
Good point. Does the ES 5 support need a new major @kdambekalns?
There was a problem hiding this comment.
No it does not IMHO, and in fact I'd love to see that merged into 3.0 as indicated on #220.
There was a problem hiding this comment.
But, @dfeyer what about the 4.0.x releases that have been created off of the master branch!?
There was a problem hiding this comment.
oh right, forgot there's a 4.x version
kdambekalns
changed the title
|
Ok, I'll adjust that. |
kdambekalns
changed the title
5 participants
No description provided.