BUGFIX: Fix error handling#240
Merged
kdambekalns merged 3 commits intoFlowpack:masterfrom Jan 15, 2018
Merged
Conversation
If the expected alias was missing, the command would die with
Notice: Trying to get property of non-object in
NodeIndexCommandController.php line 306
When / and /sites are to be indexed, it is rather unsurprising to not
find a fulltext root. Thus this changes skips these messages:
NodeIndexer: No fulltext root found for node / (...)
NodeIndexer: No fulltext root found for node /sites (0...)
for the root and sites node.
Contributor
|
👍🏼 |
Member
Author
|
@daniellienert Is that consciously not a formal review, or …? |
Contributor
|
@kdambekalns thats a read-the-code-on-my-phone-app-which-has-no-review-button kind of a review :) |
daniellienert
approved these changes
Jan 13, 2018
Member
Author
|
@daniellienert Ah, ok. But… there is a review button on mobile, under the changes tab. At the bottom: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.