BUGFIX: Fix Policy to properly trigger authentication for GraphQL queries/mutations#307
Merged
Conversation
…ries/mutations Fixes: #305
Member
|
Amazing, thx 😆 |
Member
|
Unit tests are not happy |
The Queries privilege target matched all public methods of MediaApi including __construct, so mere instantiation of the class required authentication - breaking functional tests and any unauthenticated context that injects MediaApi. Related: #305 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
|
I tested it and it seems to resolve the issue for us 👍 |
Member
|
Thx! So this resolves #305 now? |
Sebobo
self-requested a review
July 22, 2026 12:44
Sebobo
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Policy.yamlstill referred to some no-longer usedt3n\GraphQLnamespace. By fixing the method privilege matcher to point to public methods of theMediaApiclass, the PolicyEnforcementAspect is properly invoked, triggering authentication.Fixes: #305