Fix recurring-date drift, add missing lib/e2e/a11y test coverage - #326
Merged
Austinaminu2 merged 1 commit intoJul 24, 2026
Merged
Conversation
…, FlowwStar#296, FlowwStar#299, FlowwStar#300) - lib/recurring.ts: buildNextRunAt now adds real calendar months/quarters (with end-of-month clamping) instead of fixed 30/90-day offsets, fixing renewal-date drift around February and 31-day months. (FlowwStar#293) - Add unit tests for previously-untested lib/ utilities named in the coverage audit: __tests__/lib/recurring.test.ts (calendar-month edge cases, persistence, upcoming-renewal sorting) and __tests__/lib/address-book.test.ts (CRUD + touch/persist behavior). lib/csv-parser.ts, lib/error-messages.ts, and lib/receipt-utils.ts already have comprehensive tests in __tests__/lib/. (FlowwStar#296) - Add e2e/settings.spec.ts (display-preference persistence, webhook register/toggle/remove/validate, persistence across reload) and e2e/analytics.spec.ts (chart rendering against the app's built-in mock data store, range-filter behavior, empty-state copy). (FlowwStar#299) - Expand e2e/accessibility.spec.ts with axe scans for the new settings/analytics pages, complementing the existing automated a11y scans and focus-trap/keyboard-nav coverage for dashboard, create-stream, and the cancel-stream / tx-preview / fee dialogs. (FlowwStar#300) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTXYLUrw8kW1yWzcpDq8Cn
|
@Genghis-codes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #293
Closes #296
Closes #299
Closes #300
buildNextRunAtinlib/recurring.tsnow adds real calendar months/quarters (with end-of-month clamping) instead of fixed 30/90-day offsets, fixing renewal-date drift.lib/recurring.ts(calendar-month edge cases) andlib/address-book.ts(CRUD, dedup, cap, malformed-storage handling).e2e/settings.spec.tsande2e/analytics.spec.tscovering settings persistence and analytics chart rendering.e2e/accessibility.spec.tswith axe scans for the new settings/analytics pages.