fix(streaming): wire delegate authorization in withdraw() and document auth model - #329
Merged
Austinaminu2 merged 1 commit intoJul 25, 2026
Conversation
…t auth model Previously withdraw() called stream.recipient.require_auth() unconditionally, ignoring any delegate registered via set_delegate(). Registered delegates could never authorize a withdrawal despite being stored. The fix checks Delegate(stream_id) in persistent storage first; when a delegate is present the delegate's auth is required (they act on behalf of the recipient, with tokens still sent to the recipient). When no delegate is registered the original recipient-auth path is used unchanged. Clarify the doc-comment to make the exclusive-delegate semantics explicit so callers understand that setting a delegate transfers withdrawal authority. Closes FlowwStar#265
|
@Devdave-0x Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withdraw()previously calledstream.recipient.require_auth()unconditionally, ignoring theDelegate(stream_id)storage entry written byset_delegate()Delegate(stream_id)first; when a delegate is present,delegate.require_auth()is called instead — the delegate acts on behalf of the recipient with tokens still sent to the recipient's addressTest plan
test_auth_delegate_can_withdraw(test_security.rs) — delegate can now authorize a withdrawaltest_auth_recipient_cannot_withdraw_without_delegate_auth_when_delegate_set— correctly panics when only recipient auth is provided but a delegate is activeCloses #265