fix(hooks): add unmount cleanup to useBatchCreate - #335
Merged
Austinaminu2 merged 1 commit intoJul 25, 2026
Merged
Conversation
useBatchCreate started a batch operation but had no cleanup on unmount, so the running batch would continue posting state updates to an already- unmounted component. Add a useEffect that sets abortRef.current = true on cleanup, mirroring what the existing cancel() callback does. The abortRef flag is already checked at the top of every loop iteration in both createBatch and retryFailed, so setting it on unmount is sufficient to stop any in-progress batch without further changes. Closes FlowwStar#274
|
@coredevdave-cmd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useBatchCreatestarted batch stream creation but had no cleanup on unmount, so the running batch continued postingsetProgressupdates to an already-unmounted componentuseEffectwith a cleanup function that setsabortRef.current = trueon unmount — the same flag already checked at the top of every loop iteration in bothcreateBatchandretryFaileduseEffectfrom React (was not previously imported)The cleanup mirrors what the existing
cancel()callback does, making unmount behaviour automatic rather than relying on callers to callcancel()before the component unmounts.Test plan
useBatchCreateand starts a long batch; unmount it mid-batch; confirm no ReactsetStatewarnings appear in the consolecancel()still works as before for explicit early terminationCloses #274