DEV-26740 Improvements when importing cells, images, links and styles#68
Merged
Conversation
harvestcore
reviewed
Apr 20, 2026
| * Use this with caution, as this XML may differ from the | ||
| * content of DocumentXml as soon as it is used. | ||
| */ | ||
| #initialRawXml: Document | null = null; |
Collaborator
There was a problem hiding this comment.
I'd rename this to xml.
harvestcore
reviewed
Apr 21, 2026
harvestcore
reviewed
Apr 21, 2026
harvestcore
reviewed
Apr 21, 2026
Collaborator
|
LGTM, but please take a look at the comments. |
Author
|
All your suggestions have been added! @harvestcore |
thebassplayer1234
approved these changes
Apr 21, 2026
ins426
approved these changes
Apr 21, 2026
| "shading": ./${QNS.w}tcPr/${QNS.w}shd/docxml:ct-shd(.), | ||
| "borders": ./${QNS.w}tcPr/${QNS.w}tcBorders/map { | ||
| "top": docxml:ct-border(${QNS.w}top), | ||
| "start": docxml:ct-border((${QNS.w}start|${QNS.w}left)[1]), |
There was a problem hiding this comment.
Why does it take the first value? (same question for bottom too)
| "shading": ./${QNS.w}tcPr/${QNS.w}shd/docxml:ct-shd(.), | ||
| "borders": ./${QNS.w}tcPr/${QNS.w}tcBorders/map { | ||
| "top": docxml:ct-border(${QNS.w}top), | ||
| "start": docxml:ct-border((${QNS.w}start|${QNS.w}left)[1]), |
There was a problem hiding this comment.
Also according to the schema border doesn't have any start or end child https://c-rex.net/samples/ooxml/e1/Part4/OOXML_P4_DOCX_tcBorders_topic_ID0EBWRR.html#topic_ID0EBWRR
There was a problem hiding this comment.
I have talked with Luis and it seems that these are from an old schema. We can keep it for now, but I'd prefer the current schema tbh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.