DEV-26894 Add height to table row properties#76
Merged
Conversation
harvestcore
approved these changes
May 19, 2026
thebassplayer1234
approved these changes
May 20, 2026
| * - `value`: the height of the row. | ||
| * - `rule`: how the height is applied: | ||
| * - `'auto'`: the row height is determined by the content. | ||
| * - `'atLeast'` (default when omitted): the row height is at least the specified value. |
There was a problem hiding this comment.
The documentation says that 'auto' is the default option when omitted, no?
https://c-rex.net/samples/ooxml/e1/Part4/OOXML_P4_DOCX_trHeight_topic_ID0E5G4R.html?hl=trheight
luiisgallego
requested changes
May 20, 2026
| */ | ||
| height?: null | { | ||
| value: Length; | ||
| rule?: null | 'auto' | 'atLeast' | 'exact'; |
There was a problem hiding this comment.
If the default is “auto,” I would never set it to “null.”
There was a problem hiding this comment.
Discussed with the team via chat and "null" is fine.
luiisgallego
approved these changes
May 20, 2026
luiisgallego
left a comment
luiisgallego
left a comment
There was a problem hiding this comment.
Please update the 'rule' (default value) documentation before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.