Add support for cell margins (w:tcMar) in Cell - #81
Merged
Conversation
luiisgallego
approved these changes
Jul 14, 2026
| "insideV": docxml:ct-border(${QNS.w}insideV) | ||
| }, | ||
| "margin": ./${QNS.w}tcPr/${QNS.w}tcMar/map { | ||
| "top": if (${QNS.w}top/@${QNS.w}w) |
There was a problem hiding this comment.
Is the condition really needed? I think you can call 'docxml:length' directly.
| : null, | ||
| margin: | ||
| tcpr.margin && | ||
| (tcpr.margin.top || |
There was a problem hiding this comment.
This code is strange, follow "change" prop idea.
| "insideV": docxml:ct-border(${QNS.w}insideV) | ||
| }, | ||
| "margin": ./${QNS.w}tcMar/map { | ||
| "top": if (${QNS.w}top/@${QNS.w}w) |
There was a problem hiding this comment.
Remove conditions if they are not fully required
| * Each side is a {@link Length}. Omitted sides fall back to the table default. | ||
| */ | ||
| margin?: null | { | ||
| top?: null | Length; |
Author
There was a problem hiding this comment.
The documentation for this prop is in line 48 to 53
| * both `w:start` and the legacy `w:left` are accepted when reading. | ||
| */ | ||
| start?: null | Length; | ||
| bottom?: null | Length; |
Author
There was a problem hiding this comment.
The documentation for this prop is in line 48 to 53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr add support for table cell prop
<w:tcMar>.