chore(deps): bump golang.org/x/crypto v0.55.0 -> v0.56.0 (govulncheck) - #1689
Conversation
govulncheck started failing on every PR after the vuln DB picked up two advisories against golang.org/x/crypto@v0.55.0's ssh.NewClientConn path (GO-2026-6354, GO-2026-6355), both fixed in v0.56.0. Unrelated to any of the Phase 1 (#1682) work in flight — found while trying to merge #1687, which doesn't touch this dependency at all. The CI gate only fails on a vulnerability with an actual available fix (`grep "Fixed in:" | grep -v N/A`); the remaining reported findings (several github.com/lxc/incus/v6 CVEs, one golang.org/x/crypto/openpgp advisory) all show "Fixed in: N/A" — no upstream fix exists yet, so they don't block and this bump doesn't touch them. Verified locally: govulncheck -show verbose ./... after the bump reports zero non-N/A "Fixed in:" lines. go.sum churn is minimal (2 lines) — no cascading dependency bumps.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe direct ChangesCrypto dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized dependency update with no actionable merge-blocking risk remaining after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
govulncheckstarted failing on every open PR after the vulnerability DB picked up two advisories againstgolang.org/x/crypto@v0.55.0'sssh.NewClientConnpath (GO-2026-6354, GO-2026-6355) — both fixed in v0.56.0. Unrelated to any of the Phase 1 (#1682) work in flight; found while trying to merge #1687, which doesn't touch this dependency.The CI gate only fails when a reported vulnerability has an actual available fix:
Everything else currently reported — several
github.com/lxc/incus/v6CVEs, onegolang.org/x/crypto/openpgpadvisory — showsFixed in: N/A(no upstream fix exists yet), so it doesn't block and this bump doesn't touch it.Verification
Ran locally after the bump:
Zero
Fixed in:lines that aren'tN/A— the exact condition the CI gate checks.go.sumchurn is minimal (2 lines), no cascading dependency bumps.Test evidence
go build ./...,go vet ./...,gofmt -l— clean.go test ./...— green except the same two pre-existingtest/integrationfailures every run in this sandbox hits (need a live daemon + real TLS certs, unrelated to this change).This should merge ahead of #1687/#1684/#1686/#1688 so they inherit the fix on their next rebase.
Summary by CodeRabbit